[PATCH] D15792: [AArch64] Turn off PredictableSelectIsExpensive on the Cortex-A57

[Renato Golin via llvm-commits]

rengolin added a comment.

In http://reviews.llvm.org/D15792#321176, @flyingforyou wrote:

> James, I still think this commit might be worth for Cortex-A57. Could you give me a second chance, please?


The status is "needs revision", not "refused". :)

If you get new numbers that prove this is a good move, you should definitely try again.

The hint is to do yourself the analysis that James did. Look at the numbers with care, make sure that they're consistent and if they're not, investigate why not, and only publicise your findings when you're sure that every corner was swept and you have an answer to all issues with the data.

In a nutshell, always distrust your own numbers until you prove yourself that they're good.

cheers,
--renato


http://reviews.llvm.org/D15792