[PATCH] D14665: Support literal structs in mangled intrinsics.

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 6 18:57:13 PST 2016


reames added a comment.

LGTM.  The explanation on the non-literal form makes sense.  I'm still not happy about the break in the naming scheme, but I don't have a better option either.

Just for the record, this really should have been two patches.  One was a minor enhancement, the other was a subtle change which required careful thought.  Please make sure when you land this that you call out the issue here so that it's obvious to readers.


http://reviews.llvm.org/D14665





More information about the llvm-commits mailing list