[PATCH] D14308: [SimplifyCFG] Extend SimplifyResume to handle phi of trivial landing pad.

[Chen Li via llvm-commits]

chenli added inline comments.

================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:3294
@@ +3293,3 @@
+
+  // Delete the resume block if all its predecessors have been removed.
+  if (pred_empty(BB))
----------------
reames wrote:
> Hm, what about an empty phi in an unreachable block?  I think you're probably guarded from getting here, but adding an assert to make that clear would be good.  
I didn't quite get this. If the resume block has no predecessor and become unreachable, it should contains an empty phi. Do you mean I should assert the empty phi is there?


http://reviews.llvm.org/D14308