[PATCH] D15913: Consolidate MemRefs handling from BranchFolding and correct latent bug

[Geoff Berry via llvm-commits]

gberry added inline comments.

================
Comment at: lib/CodeGen/BranchFolding.cpp:796
@@ -795,3 +784,1 @@
-      if (!hasIdenticalMMOs(&*MBBI, &*MBBICommon))
-        MBBICommon->dropMemRefs();
 
----------------
reames wrote:
> reames wrote:
> > gberry wrote:
> > > I think dropMemRefs() is dead after this change, so it could also be removed.
> > Good catch.
> Actually, after further though, I'm going to leave the routine.  The semantic operation it performs is useful and not really clear from any of the other accessors.  
> 
> I may change my mind when I try to actually introduce the poison state, but that can be part of that review.  
Yeah, I had a similar thought after I sent the original comment.


http://reviews.llvm.org/D15913