[PATCH] D15909: [llvm-symbolizer] -print-source-context-lines option to print source code around the line.

Alexey Samsonov via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 6 10:42:54 PST 2016


samsonov added inline comments.

================
Comment at: tools/llvm-symbolizer/llvm-symbolizer.cpp:218
@@ +217,3 @@
+      Printer << DebugInfo;
+      for (uint32_t I = 0; I < DebugInfo.getNumberOfFrames(); ++I) {
+        printContextIfNeeded(DebugInfo.getFrame(I).FileName,
----------------
This will be confusing: first you will print several blocks with function/file/lineno, and then several blocks with source code. Shouldn't they be interchanged? Probably source code printing can be implemented in DIPrinter.


http://reviews.llvm.org/D15909





More information about the llvm-commits mailing list