[PATCH] D15927: ScheduleDAGInstrs: Bug fix for missed memory dependency.

Andrew Trick via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 6 09:19:26 PST 2016


atrick accepted this revision.
atrick added a comment.
This revision is now accepted and ready to land.

LGTM with my suggestion for a comment.


================
Comment at: lib/CodeGen/ScheduleDAGInstrs.cpp:1140
@@ -1142,1 +1139,3 @@
                              RejectMemNodes);
+        if (MayAlias)
+          adjustChainDeps(AA, MFI, MF.getDataLayout(), SU, &ExitSU,
----------------
I would be nice to add a short comment explaining why addChainDependency and adjustChainDeps need to be called in this order.


http://reviews.llvm.org/D15927





More information about the llvm-commits mailing list