[PATCH] D15919: Revert "GlobalsAA: Take advantage of ArgMemOnly, InaccessibleMemOnly and InaccessibleMemOrArgMemOnly attributes"

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 6 05:20:29 PST 2016


jmolloy accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: lib/Analysis/GlobalsModRef.cpp:388
@@ -387,3 +379,2 @@
-        }
       }
     } else if (ICmpInst *ICI = dyn_cast<ICmpInst>(I)) {
----------------
deadalnix wrote:
> vaivaswatha wrote:
> > In my opinion, this part can actually stay. I'll let the others decide though.
> Even if we want to go that road, I think it makes sense to do a clean revert and then reintroduce the changes that makes sense in their own diifs, with their own tests.
Agreed. Let's just do the revert and then reapply any applicable hunks with tests.


http://reviews.llvm.org/D15919





More information about the llvm-commits mailing list