[PATCH] D15553: PR25717: fatal IO error writing large outputs to console on Windows

Yunzhong Gao via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 5 19:21:33 PST 2016


ygao added a comment.

Ok, I had to modify the fix somewhat to make a mingw bot happy. The bot is
i686-mingw32-RA-on-linux.

Issue#1: this bot does not ship with VersionHelpers.h. I am not sure whether it is a mingw32
bot or it happens to be using a very old mingw-w64. Looking at the buildslave config page,
http://bb.pgr.jp/buildslaves/centos6, it says gcc 4.4.6.

In r256896, I tried to fix the problem by testing for mingw32; and in r256901, I tried testing
"__MINGW64_VERSION_MAJOR < 3". Neither approach seems to fix the buildbot. So for now
I am not including VersionHelpers.h on mingw (same as cygwin).

Issue#2: I had to take out the NOGDI macro from WindowsSupport.h in r256904 because
mingw defines LOGFONTW type in wingdi.h. The mingw version of shlobj.h (needed by
lib/Support/Windows/Path.inc) includes shobjidl.h and the latter uses the LOGFONTW type.


Repository:
  rL LLVM

http://reviews.llvm.org/D15553





More information about the llvm-commits mailing list