[PATCH] D15906: [Vectorization] Actually return from error case in isStridedPtr

[Michael Zolotukhin via llvm-commits]

mzolotukhin added a subscriber: mzolotukhin.
mzolotukhin added a comment.

The change itself looks good, but there are several things about the test that could be improved:

1. I think you don't need to run the entire O2 pipeline on the test. For instance, if the offending optimization is "loop-vectorizer", we could extract IR before it, and replace `opt -O2` with `opt -loop-vectorize` on this IR (to find the list of the O2 passes, run `opt -O2 -debug-pass=Arguments`).
2. Do you use `CHECK` + `XFAIL` only to make sure that the specified lines aren't present in the output? Could you use `CHECK-NOT` instead? Also, if you run only one pass, it will be much easier to check that nothing unexpected happened with the IR.
3. Could you please run `opt -instnamer` on the IR to avoid `%123`  and `<label>:123` names? It's very painful to edit tests with such variable names (as the numbers must be consecutive).
4. Minor point: you probably could remove function attributes.

Thanks,
Michael


http://reviews.llvm.org/D15906