[llvm] r256875 - [Statepoints] Check for the "gc-leaf-function" attribute on call sites as well.

Manuel Jacob via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 5 15:59:09 PST 2016


Author: mjacob
Date: Tue Jan  5 17:59:08 2016
New Revision: 256875

URL: http://llvm.org/viewvc/llvm-project?rev=256875&view=rev
Log:
[Statepoints] Check for the "gc-leaf-function" attribute on call sites as well.

Reviewers: sanjoy, reames

Subscribers: sanjoy, llvm-commits

Differential Revision: http://reviews.llvm.org/D15900

Modified:
    llvm/trunk/lib/Transforms/Utils/Local.cpp
    llvm/trunk/test/Transforms/PlaceSafepoints/leaf-function.ll

Modified: llvm/trunk/lib/Transforms/Utils/Local.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/Local.cpp?rev=256875&r1=256874&r2=256875&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/Local.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/Local.cpp Tue Jan  5 17:59:08 2016
@@ -1553,8 +1553,8 @@ bool llvm::callsGCLeafFunction(Immutable
     return true;
 
   // Check if the function is specifically marked as a gc leaf function.
-  //
-  // TODO: we should be checking the attributes on the call site as well.
+  if (CS.hasFnAttr("gc-leaf-function"))
+    return true;
   if (const Function *F = CS.getCalledFunction())
     return F->hasFnAttribute("gc-leaf-function");
 

Modified: llvm/trunk/test/Transforms/PlaceSafepoints/leaf-function.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/PlaceSafepoints/leaf-function.ll?rev=256875&r1=256874&r2=256875&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/PlaceSafepoints/leaf-function.ll (original)
+++ llvm/trunk/test/Transforms/PlaceSafepoints/leaf-function.ll Tue Jan  5 17:59:08 2016
@@ -1,6 +1,7 @@
 ; RUN: opt %s -S -place-safepoints | FileCheck %s
 
 declare void @foo() "gc-leaf-function"
+declare void @bar()
 
 ; Calls of functions with the "gc-leaf-function" attribute shouldn't be turned
 ; into a safepoint.  An entry safepoint should get inserted, though.
@@ -14,6 +15,16 @@ entry:
   ret void
 }
 
+define void @test_leaf_function_call() gc "statepoint-example" {
+; CHECK-LABEL: test_leaf_function_call
+; CHECK: gc.statepoint.p0f_isVoidf
+; CHECK-NOT: statepoint
+; CHECK-NOT: gc.result
+entry:
+  call void @bar() "gc-leaf-function"
+  ret void
+}
+
 ; This function is inlined when inserting a poll.
 declare void @do_safepoint()
 define void @gc.safepoint_poll() {




More information about the llvm-commits mailing list