[PATCH] D15250: Detecte vector reduction operations just before instruction selection.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 5 10:22:14 PST 2016


RKSimon added a comment.

One minor think I noticed, but overall I don't know this code well enough to review, sorry.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:2338
@@ +2337,3 @@
+      if (FPOp->getFastMathFlags().unsafeAlgebra())
+        break;
+  default:
----------------
return false here or add a 'fall through' comment here to make it clear that its intentional


http://reviews.llvm.org/D15250





More information about the llvm-commits mailing list