[PATCH] Teach CMake build system to run lit's own test suite

[Chris Bieneman via llvm-commits]

LGTM.

I was thinking about your original email’s issue 1 (is this the right implementation), and I had a few thoughts.

TL;DR: yes, and if I’m wrong it is at least a good starting point.

I think the only real benefit you could get from making check-lit a prerequisite of the other check targets is that we could bail early, and potentially we could not re-run the check-lit tests if lit didn’t change between runs of other check targets. I don’t think adding that support later would be particularly hard, so your implementation is good. I’m also not sure that adding that extra functionality is really worth it. The check-lit tests are pretty fast, and I imagine that with good parallelism they really shouldn’t add much to a check-all run (maybe I’m wrong about this, I’m on my laptop in the SLC airport, so I can’t easily verify).

Either way, this patch is an improvement over what we have, so let’s go with it.

Thanks,
-Chris

> On Dec 29, 2015, at 10:35 PM, Dan Liew <dan at su-root.co.uk> wrote:
> 
>> I'll investigate and hopefully will have a new patch that fixes this soon.
> 
> 
> Okay I fixed the issue (see attached patch). The PYTHONPATH
> environment variable wasn't being set correctly.
> <0001-Teach-the-CMake-build-system-to-run-lit-s-tests.-The.v4.patch>