[PATCH] D15757: Extract helper function to merge MemoryOperand lists [NFC]

Junmo Park via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 4 19:50:02 PST 2016


flyingforyou added inline comments.

================
Comment at: lib/CodeGen/MachineInstr.cpp:884
@@ +883,3 @@
+                     MemEnd);
+  assert(MemEnd - MemBegin == CombinedNumMemRefs && "missing memrefs");
+  
----------------
I mean `NumMemRefs` is in MachineInstr.

If MI1's MMOs count is 1, Other MI's MMOs count is 2, we should update MI1's MMOs count(`NumMemRefs`) 3.
concatenateMemOperands assume that MI1's MMOs count is zero. But If we want to make interface about merging MMOs, we might update `NumMemRefs`.


http://reviews.llvm.org/D15757





More information about the llvm-commits mailing list