[PATCH] D15696: [ThinLTO] Enable in-place symbol changes for exporting module

[Mehdi AMINI via llvm-commits]

joker.eph accepted this revision.
joker.eph added a comment.
This revision is now accepted and ready to land.

Thanks for this patch, I was complaining about the ModuleLinker doing to much stuff in a review a few weeks ago, and splitting it / extracting pieces is definitively something valuable.


================
Comment at: lib/Linker/LinkModules.cpp:130
@@ +129,3 @@
+      : Mover(Mover), SrcM(SrcM), Flags(Flags), ImportIndex(Index),
+        FunctionsToImport(FunctionsToImport), ValIDToTempMDMap(ValIDToTempMDMap) {
+    assert((ImportIndex || !FunctionsToImport) &&
----------------
clang-format

================
Comment at: lib/Linker/LinkModules.cpp:191
@@ -133,1 +190,3 @@
+  GlobalValue::LinkageTypes getLinkage(const GlobalValue *SGV);
+
   /// Process globals so that they can be used in ThinLTO. This includes
----------------
Why was this declaration moved? Keeping it after `processGlobalForThinLTO` allows for a smaller diff.


http://reviews.llvm.org/D15696