[PATCH] D15880: [BasicAA] Delete dead code related to memset/memcpy/memmove intrinsics [NFCI]

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 4 17:50:26 PST 2016


reames created this revision.
reames added reviewers: chandlerc, dberlin, hfinkel.
reames added a subscriber: llvm-commits.

We only need to describe the writeonly property of one of the arguments.  All of the rest of the semantics are nicely described by existing attributes in Intrinsics.td.  

http://reviews.llvm.org/D15880

Files:
  lib/Analysis/BasicAliasAnalysis.cpp

Index: lib/Analysis/BasicAliasAnalysis.cpp
===================================================================
--- lib/Analysis/BasicAliasAnalysis.cpp
+++ lib/Analysis/BasicAliasAnalysis.cpp
@@ -599,9 +599,11 @@
     case Intrinsic::memset:
     case Intrinsic::memcpy:
     case Intrinsic::memmove:
-      assert((ArgIdx == 0 || ArgIdx == 1) &&
-             "Invalid argument index for memory intrinsic");
-      return ArgIdx ? MRI_Ref : MRI_Mod;
+      // We don't currently have a writeonly attribute.  All other properties
+      // of these intrinsics are nicely described via attributes in
+      // Intrinsics.td and handled generically below.
+      if (ArgIdx == 0)
+        return MRI_Mod;
     }
 
   // We can bound the aliasing properties of memset_pattern16 just as we can


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15880.43952.patch
Type: text/x-patch
Size: 789 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160105/5d521d5d/attachment.bin>


More information about the llvm-commits mailing list