[PATCH] D15830: [PGO] Enable building compiler-rt profile support library on Windows

David Li via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 4 16:08:58 PST 2016


davidxl added inline comments.

================
Comment at: lib/profile/CMakeLists.txt:40
@@ -39,1 +39,3 @@
 
+if(MSVC)
+    list(APPEND PROFILE_SOURCES WindowsMMap.c)
----------------
This is not needed if the source file is properly guarded -- see other platform specific files.

================
Comment at: lib/profile/WindowsMMap.c:21
@@ +20,3 @@
+
+#if defined(_WIN32)
+
----------------
Move this line above the first include.


http://reviews.llvm.org/D15830





More information about the llvm-commits mailing list