[PATCH] D7864: This patch introduces MemorySSA, a virtual SSA form for memory.Details on what it looks like are in MemorySSA.h

[Hal Finkel via llvm-commits]

hfinkel added a comment.

Thanks for the update!

Quick comment (just so I don't forget), there are a few places that have:

  assert(N < 10000 && ..)

that need to become actual conservative bailouts instead of asserts.


================
Comment at: lib/Transforms/Utils/MemorySSA.cpp:1284
@@ +1283,3 @@
+  if (const LoadInst *LI = dyn_cast<LoadInst>(I))
+    if (LI->getMetadata(LLVMContext::MD_invariant_load) != nullptr) {
+      doCacheInsert(StartingAccess, MSSA->getLiveOnEntryDef(), Q,
----------------
You might also want to check AA->pointsToConstantMemory here.


http://reviews.llvm.org/D7864