[PATCH] D15746: Normalize the features string in SubtargetFeatures::getFeatureBits

[Eric Christopher via llvm-commits]

echristo added a comment.

Hi,

Couple of things:

a) could you split this out? I agree that the changes to SubtargetFeatures::ToggleFeature and SubtargetFeatures::ApplyFeatureFlag look good and should be committed, but separately since the rest should have some discussion.

b) I agree with the overall notion of this, that said, I think this might be the wrong way to achieve it. How are you getting the feature strings that you're showing here? If you've got a feature that is transitively enabled or disabled by another feature then you've got a set and not a feature and it should probably be split accordingly and not just based on command line option. I think knowing the answer to my first question will show how to proceed here though.

-eric


http://reviews.llvm.org/D15746