[PATCH] D15828: [PGO] Passmanagerbuilder change that enable IR level PGO instrumentation

[Rong Xu via llvm-commits]

On Wed, Dec 30, 2015 at 2:54 PM, David Li <davidxl at google.com> wrote:
> davidxl added inline comments.
>
> ================
> Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:208
> @@ +207,3 @@
> +  // Preinstrumenation inline. Set the OptLevel to 1 to limit the inlining.
> +  MPM.add(createFunctionInliningPass(1, SizeLevel));
> +  if (OptLevel != 0) {
> ----------------
> Is it better to do max(SizeLevel, 1) instead of SizeLevel?

Yes. I meant to use Os as the sizelevel (unless Oz is specified).
So, it should be max(SizeLevel, 1) here.

Thanks for catching this.

>
>
> http://reviews.llvm.org/D15828
>
>
>