[PATCH] D15828: [PGO] Passmanagerbuilder change that enable IR level PGO instrumentation

David Li via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 3 12:42:23 PST 2016


davidxl added inline comments.

================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:281
@@ -239,1 +280,3 @@
 
+  addPGOInstrPasses(MPM);
+
----------------
joker.eph wrote:
> There will be an inliner SCC pass manager created in the PGO InstrPasses. It is not clear to me why you don't integrate this with the regular inliner a few line below.
This is the pre-inline pass that needs to happen before instrumentation. See the original RFC: http://lists.llvm.org/pipermail/llvm-dev/2015-August/089425.html for details.


http://reviews.llvm.org/D15828





More information about the llvm-commits mailing list