[PATCH] D15830: [PGO] Enable building compiler-rt profile support library on Windows

[Xinliang David Li via llvm-commits]

On Wed, Dec 30, 2015 at 3:37 PM, Nathan Slingerland <slingn at gmail.com> wrote:
> slingn added a comment.
>
> mmap-windows.c gets #included directly in GCDAProfiling.c since the compatibility mmap()/msync()/flock() functions are not used anywhere else (they are static).
>
> I agree it is a bit odd - and CMake won't properly detect changes to mmap-windows.c the way things are now. Perhaps it would be better to mark them with COMPILER_RT_VISIBILITY (and not static).

yes. I also expect mmap to be used in other parts of profile_rt in the
future when more features are added.

David
>
>
> http://reviews.llvm.org/D15830
>
>
>