[PATCH] D15801: Improve the documentation on committing code reviewed on Phabricator to trunk.

[Paul Robinson via llvm-commits]

probinson added a subscriber: probinson.
probinson added a comment.

Thanks for describing the git-svn sequence.  Some inline comments.


================
Comment at: docs/Phabricator.rst:132
@@ +131,3 @@
+committed to trunk.  There are multiple workflows to achieve this. Which
+ever method you follow you must ensure that your commit message ends with
+the line:
----------------
"Whichever" is one word.

================
Comment at: docs/Phabricator.rst:146
@@ +145,3 @@
+
+Note that if you use the Arcanist tool this line will be added this
+automatically. If you don't want to use Arcanist just commit as
----------------
Remove the last "this" on the line.

================
Comment at: docs/Phabricator.rst:148
@@ +147,3 @@
+automatically. If you don't want to use Arcanist just commit as
+normal making sure the commit message is formatted as mentioned above.
+
----------------
I'd write that last sentence in a more active-voice style: "If you don't want to use Arcanist, you will need to add the Differential Revision line to the commit message yourself."



http://reviews.llvm.org/D15801