[PATCH] D15781: [compiler-rt] Add support for ARM EHABI to gcc_personality_v0.

[Saleem Abdulrasool via llvm-commits]

compnerd added a comment.

I agree that there are multiple points of discussion here.  Focusing solely on __gcc_personality_v0 is probably prudent.

I don't think that anyone has shown that the current implementation does not work on ARM.  I recall using the current implementation during testing on ARMv7.  I may be mistaken, so we should double check that.

The reason that I'm unhappy about changing the signature here is because this is not a generic routine, it is a language specific implementation.  The change actually breaks ABI.

The reason that you are able to generate references in your example is due to the C specific exception handling.  It is similar to using C++ with exceptions and seeing references to __gxx_personality_v0.

AFAIR, EHABI has no bearing on the language specific handling which is why it doesn't matter if this routine doesn't match its signature.


http://reviews.llvm.org/D15781