[PATCH] D15783: Make timestamp writing in WinCOFFObjectWriter.cpp independent of ENABLE_TIMESTAMPS

[Nico Weber via llvm-commits]

thakis created this revision.
thakis added reviewers: majnemer, chapuni.
thakis added a subscriber: llvm-commits.

LLVM_ENABLE_TIMESTAMPS controls if timestamps are embedded into llvm's binaries. Turning it off is useful for deterministic builds.

r246905 made it so that the define suddenly also controls if the binaries that the llvm binaries _create_ embed timestamps or not – but this shouldn't be a configure-time option. r256203/r256204 added a driver option to toggle this on and off, so this patch now passes this driver option in LLVM_ENABLE_TIMESTAMPS builds so that if LLVM_ENABLE_TIMESTAMPS is set, the build of LLVM is deterministic – but the built clang can still write timestamps into other executables when requested.

This also allows removing some of the test machinery added in r292012 to work around this problem.

See PR24740 for background.

http://reviews.llvm.org/D15783

Files:
  cmake/modules/HandleLLVMOptions.cmake
  lib/MC/WinCOFFObjectWriter.cpp
  test/MC/COFF/timestamp.s
  test/lit.cfg
  test/lit.site.cfg.in

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15783.43646.patch
Type: text/x-patch
Size: 4117 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151226/c06ac5c8/attachment.bin>