[PATCH] D15753: WebAssembly: remove 'external' from test

Dan Gohman via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 23 15:39:19 PST 2015


sunfish accepted this revision.
sunfish added a comment.
This revision is now accepted and ready to land.

As we discussed on IRC, this test was using external intentionally, because that's a useful thing to test, and the problem is that these tests are being use to generate tests for other tools in which external doesn't make sense. I'm ok with this change as a workaround for now, but please add a TODO comment reminding us to go back and revisit this.


http://reviews.llvm.org/D15753





More information about the llvm-commits mailing list