[PATCH] D15754: AMDGPU/SI: Simplify validation of flat instructions optional operands

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 23 13:21:42 PST 2015


arsenm added a comment.

Typo in message: validateTargetOprandClass


================
Comment at: lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:1332
@@ -1329,1 +1331,3 @@
 
+static bool isTokenValidOptionalOp(const ArrayRef<OptionalOperand> &Operands,
+                                   StringRef Token) {
----------------
ArrayRef should be passed by value


http://reviews.llvm.org/D15754





More information about the llvm-commits mailing list