[PATCH] D15730: [MachineLICM] Fix handling of memoperands
Sanjoy Das via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 22 20:13:17 PST 2015
sanjoy added a comment.
[-CC all]
Philip Reames wrote:
> reames added a comment.
>
> In http://reviews.llvm.org/D15730#315931, @sanjoy wrote:
>
> > (Side note: `NumMemRefs` is an `uint16_t` -- does this mean the limit is 65536, and not 256?)
>
>
> Where are you looking? The one in MachineInstr.h is definitely an uint8_t. I just triple checked.
>
> Oh, wait. I think you're looking at our downstream tree right? I think we patched that locally.
The perils of living downstream. :)
I was the one who added this in Apr 24 2014; but somehow the leading
"/// AZUL BEGIN" got lost, possibly in some upstream merge. I'll add it
back.
- Sanjoy
> http://reviews.llvm.org/D15730
http://reviews.llvm.org/D15730
More information about the llvm-commits
mailing list