[PATCH] D15703: [AVR] Add instruction definitions
Roel Jordans via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 22 19:14:11 PST 2015
rjordans added a subscriber: rjordans.
================
Comment at: lib/Target/AVR/AVRInstrInfo.td:58
@@ +57,3 @@
+// shift nodes
+def AVRlsl : SDNode<"AVRISD::LSL", SDTIntUnaryOp>;
+def AVRlsr : SDNode<"AVRISD::LSR", SDTIntUnaryOp>;
----------------
arsenm wrote:
> These custom shift nodes look strange. It looks like the shift amount is passed in an implicit register, but you aren't adding glue to the node for the copy into it
AVR only has shift-by-1 kind of operations so they don't get a shift amount specified through a register
http://reviews.llvm.org/D15703
More information about the llvm-commits
mailing list