[PATCH] D15540: [PGO] differentiate FE instrumentation and IR level instrumentation profiles

David Li via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 21 11:11:29 PST 2015


davidxl added a comment.

As a follow up, there should also be a change in Clang FE that checks IR level profile is not misused by FE.


================
Comment at: include/llvm/ProfileData/InstrProfReader.h:120
@@ -117,3 +119,3 @@
   TextInstrProfReader(std::unique_ptr<MemoryBuffer> DataBuffer_)
       : DataBuffer(std::move(DataBuffer_)), Line(*DataBuffer, true, '#') {}
 
----------------
Missing new field initialization.

================
Comment at: include/llvm/ProfileData/InstrProfWriter.h:30
@@ -29,2 +29,3 @@
   typedef SmallDenseMap<uint64_t, InstrProfRecord, 1> ProfilingData;
+  enum ProfKind { PF_Unknown= 0, PF_FE, PF_IRLevel };
 
----------------
Fix format.


http://reviews.llvm.org/D15540





More information about the llvm-commits mailing list