[PATCH] D15604: Changes in conversion cost model for X86 target

Nadav Rotem via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 20 22:37:00 PST 2015


nadav added a comment.

Elena, I don't understand your comment. getTypeLegalizationCost imitates the type legalizer by splitting and promoting. It actually uses the type legalizer. What do you mean it does not support zero-extend and sign-extend?

Are you saying that it does not handle dag-combine peepholes that we have? Please explain what problem your patch is solving.

I suspect that you can commit changes to the cost table not as part of this patch. But please do not modify the code that uses getTypeLegalizationCost without explaining what it does.


Repository:
  rL LLVM

http://reviews.llvm.org/D15604





More information about the llvm-commits mailing list