[PATCH] D15668: [attrs] Split off the forced attributes utility into its own pass that can be potentially run much earlier than FuncitonAttrs proper.

[Paul Robinson via llvm-commits]

probinson added a subscriber: probinson.
probinson added a comment.

One nit inline.  Fixing it as a followup would be fine.

Also it makes me vaguely uncomfortable that the list of forceable attributes is buried in this piece of code.  I guess it's for debugging/testing only, so something more formal isn't really warranted?


================
Comment at: lib/Transforms/IPO/ForceFunctionAttrs.cpp:51
@@ +50,3 @@
+      .Case("readonly", Attribute::ReadOnly)
+      .Case("argmemonly", Attribute::ArgMemOnly)
+      .Case("returns_twice", Attribute::ReturnsTwice)
----------------
I see it's a cut-and-paste but this one is out of order.


http://reviews.llvm.org/D15668