[PATCH] D15669: [ELF][MIPS] MIPS .reginfo sections handling

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/InputSection.cpp:335
@@ +334,3 @@
+    error("Invalid size of .reginfo section");
+    return 0;
+  }
----------------
error() is a _NoReturn function, so you don't need this `return 0`.

================
Comment at: ELF/InputSection.h:164
@@ -163,1 +163,3 @@
 
+// This corresponds to a MIPS .reginfo section of an input file.
+template <class ELFT>
----------------
I think this is a good place to write about MIPS Reginfo as you wrote in the patch description.

================
Comment at: ELF/InputSection.h:170
@@ +169,3 @@
+public:
+  typedef typename llvm::object::ELFFile<ELFT>::Elf_Shdr Elf_Shdr;
+
----------------
Can you move this just below the above typedef?


Repository:
  rL LLVM

http://reviews.llvm.org/D15669