[PATCH] D15581: [ELF] - fixed not properly handled @GOTTPOFF relocation against local symbols.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 19 00:21:03 PST 2015


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: ELF/InputSection.cpp:193
@@ -171,4 +192,3 @@
 
-    SymbolBody &Body = *File->getSymbolBody(SymIndex)->repl();
-
+    SymbolBody &Body = *PBody;
     if (Target->isTlsGlobalDynamicReloc(Type) &&
----------------
Can you remove variable `Body` and use *PBody instead? It now feels a bit odd to define a new variable here just to dereference PBody.


http://reviews.llvm.org/D15581





More information about the llvm-commits mailing list