[PATCH][LNT] Pass target to test-suites configure script

[Chris Matthews via llvm-commits]

Committed r256038.

> On Nov 29, 2015, at 3:47 PM, Michael Daniels <mdaniels at qnx.com> wrote:
> 
> Would you be able to commit for me?
> 
> From: chris.matthews at apple.com [chris.matthews at apple.com]
> Sent: Thursday, November 19, 2015 8:42 PM
> To: Michael Daniels
> Cc: llvm-commits at lists.llvm.org
> Subject: Re: [PATCH][LNT] Pass target to test-suites configure script
> 
> LGTM.
> 
>> On Nov 19, 2015, at 7:31 AM, Michael Daniels via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>> 
>> Hello,
>> 
>> When lnt calls test-suite's configure script, it doesn't pass in a target option and will get configured for the host instead. If the host and target are not the same, then variables like TARGET_OS will not be what's expected, so you won't really be able to compare against them.
>> 
>> So if for example I ran lnt like this from a Linux host:
>> 
>> lnt runtest nt --sandbox ./sandbox --cc i386-pc-solaris2.11-clang --test-suite ./test-suite --remote --remote-port=22 --remote-host=target_board --remote-user=user
>> 
>> Then test-suite would end up with TARGET_OS=Linux in the Makefile's, instead of the expected SunOS.
>> 
>> I have attached a potential patch that I have been using locally to work around this.
>> 
>> Thanks,
>> 
>> Mike
>> ---------------------------------------------------------------------
>> This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
>> <lnt_target.diff>_______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151218/1b4a371f/attachment.html>