[LNT] r256038 - Pass target option to test-suite

Chris Matthews via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 18 13:48:10 PST 2015


Author: cmatthews
Date: Fri Dec 18 15:48:09 2015
New Revision: 256038

URL: http://llvm.org/viewvc/llvm-project?rev=256038&view=rev
Log:
Pass target option to test-suite

When lnt calls test-suite's configure script, it doesn't pass in a
target option and will get configured for the host instead. If the host
and target are not the same, then variables like TARGET_OS will not be
what's expected, so you won't really be able to compare against them.

So if for example I ran lnt like this from a Linux host:

lnt runtest nt --sandbox ./sandbox --cc i386-pc-solaris2.11-clang
--test-suite ./test-suite --remote --remote-port=22
--remote-host=target_board --remote-user=user

Then test-suite would end up with TARGET_OS=Linux in the Makefile's,
instead of the expected SunOS.

Patch by Michael Daniels

Modified:
    lnt/trunk/lnt/tests/nt.py

Modified: lnt/trunk/lnt/tests/nt.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/tests/nt.py?rev=256038&r1=256037&r2=256038&view=diff
==============================================================================
--- lnt/trunk/lnt/tests/nt.py (original)
+++ lnt/trunk/lnt/tests/nt.py Fri Dec 18 15:48:09 2015
@@ -918,6 +918,8 @@ def configure_test_suite(config, iterati
         args.append('--with-externals=%s' %
                     os.path.realpath(config.test_suite_externals))
 
+    args.extend(['--target=%s' % config.target])
+
     print >>configure_log, '%s: running: %s' % (timestamp(),
                                                 ' '.join('"%s"' % a
                                                          for a in args))




More information about the llvm-commits mailing list