[PATCH] D15644: [asan] Use private aliases for global variables (compiler-rt part).

[Kostya Serebryany via llvm-commits]

kcc added inline comments.

================
Comment at: test/asan/TestCases/Linux/local_alias.cc:1
@@ +1,2 @@
+// RUN: %clangxx_asan -DBUILD_FOO_SO=1 -fPIC -shared %s -o %t-FOO-SO.so
+// RUN: %clangxx -DBUILD_BAR_SO=1 -fPIC -shared %s -o %t-BAR-SO.so
----------------
a comment, please

================
Comment at: test/asan/TestCases/Linux/local_alias.cc:7
@@ +6,3 @@
+
+#if defined (BUILD_FOO_SO)
+long h = 15;
----------------
name this more descriptively, e.g. BUILD_INSTRUMENTED_DSO and BUILD_UNINSTRUMENTED_DSO

================
Comment at: test/asan/TestCases/Linux/local_alias.cc:15
@@ +14,3 @@
+long foo(long *);
+long h = 12;
+long i = 13;
----------------
isn't this a real ODR which we now will fail to detect? 


Repository:
  rL LLVM

http://reviews.llvm.org/D15644