[PATCH] D15642: [asan] Use private aliases for global variables (LLVM part).

[Kostya Serebryany via llvm-commits]

kcc added subscribers: samsonov, eugenis.
kcc added a comment.

The change in general makes sense, but is potentially very intrusive, and hard to test on the small set of unit tests. 
We'll need to test it on a larger code base. Did you test it on something large? 
I afraid Chromium tests are not an adequate test target for this functionality, but it would be a good start.

Alexey, WDYT? 
One way I can see is to put this functionality under a combination of a compile-time and a run-time flags.
That'll bloat the code, but I can't see a better way to test it (other than applying the patch locally). 
__asan_global will need to be changed unconditionally, but that's ok.

Also, please don't mention the bugs in the source -- it's enough to mention them in the commit message.


Repository:
  rL LLVM

http://reviews.llvm.org/D15642