[PATCH] D15626: Add iOS/watchOS/tvOS support for ASan (compiler-rt part)

[Chris Bieneman via llvm-commits]

beanz added a comment.

Anna,

Can you please split out the CMake changes into a separate patch from the other changes? In general I think having more smaller self-contained patches will make it easier to review.

More comments inline.

Thanks,
-Chris


================
Comment at: cmake/config-ix.cmake:300-302
@@ -299,3 +299,5 @@
 
-  option(COMPILER_RT_ENABLE_IOS "Enable building for iOS - Experimental" Off)
+  option(COMPILER_RT_ENABLE_IOS "Enable building for iOS" On)
+  option(COMPILER_RT_ENABLE_TVOS "Enable building for AppleTVOS - Experimental" On)
+  option(COMPILER_RT_ENABLE_WATCHOS "Enable building for AppleWatchOS - Experimental" On)
 
----------------
I think at this point we can have iOS be on and not experimental, but can we do that as a separate patch?

tvOS and watchOS should be experimental and Off by default. There are some issues we'll need to discuss and work out to get that working in open source. Having options will be an important step for us to make it work, but the options need to be off to start with.

================
Comment at: cmake/config-ix.cmake:444
@@ +443,3 @@
+
+    if(COMPILER_RT_ENABLE_TVOS)
+      if(DARWIN_tvossim_SYSROOT)
----------------
I probably won't have time to look at this until January, but I'll help Anna rework this. I think we can set some values up front and turn the logic into a loop.


http://reviews.llvm.org/D15626