[PATCH] D15630: [WinEH] Update LCSSA to handle catchswitch with handlers inside and outside a loop

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 18 10:16:13 PST 2015


reames added a subscriber: reames.
reames added a comment.

I'm a bit concerned by this change.  Specifically, I'm worried that various optimization passes have built in assumptions about what LCSSA means.  If an optimization pass expects to have to only update PHIs in loop exists, this change could lead to crashes or potentially silent miscompiles.  Have you reviewed the loop transform passes to understand the implications of the changed invariant?


Repository:
  rL LLVM

http://reviews.llvm.org/D15630





More information about the llvm-commits mailing list