[PATCH] D15535: Use dwarfdump's frame parser instead of writing a new one in llvm-obdjump

[Pete Cooper via llvm-commits]

pete added inline comments.

================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:1629
@@ +1628,3 @@
+    // Dump the complete DWARF structure.
+    DICtx->dump(outs(), DwarfDumpType, true /* DumpEH */);
+  }
----------------
rafael wrote:
> Shouldn't this be checking DIDT_Frames?
Good question.  Wasn't sure exactly how we want to handle this.

The cl::opt I added was copied from llvm-dwarfdump so supports much more than just frames.  If we only want llvm-objdump to support frames for now then I'll remove the other options from llvm-objdump until we want to add them later.

The objdump man page lists the following, which is why I thought we could just allow pretty much anything llvm-dwarfdump has in it, but i'm happy to restrict it to frames for now:

man page: "--dwarf[=rawline,=decodedline,=info,=abbrev,=pubnames,=aranges,=macro,=frames,=frames-interp,=str,=loc,=Ranges]"


http://reviews.llvm.org/D15535