[PATCH] D15526: [mips][microMIPS] Add R_MICROMIPS_PC21_S1 relocation

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 18 07:48:24 PST 2015


dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp:165
@@ +164,3 @@
+    // Forcing a signed division because Value can be negative.
+    Value = (int64_t)Value / 2;
+    // We now check if Value can be encoded as a 21-bit signed immediate.
----------------
This is for another patch, but we ought to warn when we lose fractional bits because of these divisions.


http://reviews.llvm.org/D15526





More information about the llvm-commits mailing list