[PATCH] D15630: [WinEH] Update LCSSA to handle catchswitch with handlers inside and outside a loop

[David Majnemer via llvm-commits]

majnemer added inline comments.

================
Comment at: test/CodeGen/X86/catch-lcssa.ll:1
@@ +1,2 @@
+; RUN: opt -O2 -lcssa -S < %s | FileCheck %s
+
----------------
andrew.w.kaylor wrote:
> rnk wrote:
> > andrew.w.kaylor wrote:
> > > mzolotukhin wrote:
> > > > majnemer wrote:
> > > > > Can we move this test to "test/Transforms/LCSSA" and just use "opt -lcssa -S" ?
> > > > Also, could you please run "opt -instnamer" on the test?
> > > The reason I put it here was so that it wouldn't choke the non-X86 buildbots.  I know I could add a REQUIRES line to the test, but it doesn't seem like that is the typical way this is handled.
> > > 
> > > I'll see if I can strip it down enough to work without referencing anything X86-specific.
> > You can use an x86 target triple in opt without the x86 backend just fine. There should be other examples of this.
> I would have thought so, but I broke a bunch of buildbots that way recently.  In that case I was using the triple in the command line to run the test.  Is it possible that just having it embedded in the IR yields a different result?
IIRC, the test you added was for CodeGenPrep which is fundamentally a target-specific test.  This is test is not so it should be fine to keep it generic.


Repository:
  rL LLVM

http://reviews.llvm.org/D15630