[LNT] r255967 - More robust grouping

[Chris Matthews via llvm-commits]

Author: cmatthews
Date: Thu Dec 17 20:10:02 2015
New Revision: 255967

URL: http://llvm.org/viewvc/llvm-project?rev=255967&view=rev
Log:
More robust grouping

Sometimes parts of the orders are None (start or a machine).  Cope with that gracefully.

Modified:
    lnt/trunk/lnt/server/db/fieldchange.py

Modified: lnt/trunk/lnt/server/db/fieldchange.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/db/fieldchange.py?rev=255967&r1=255966&r2=255967&view=diff
==============================================================================
--- lnt/trunk/lnt/server/db/fieldchange.py (original)
+++ lnt/trunk/lnt/server/db/fieldchange.py Thu Dec 17 20:10:02 2015
@@ -107,10 +107,14 @@ def regenerate_fieldchanges_for_run(ts,
 
 def is_overlaping(fc1, fc2):
     """"Returns true if these two orders intersect. """
-    r1_min = fc1.start_order
-    r1_max = fc1.end_order
-    r2_min = fc2.start_order
-    r2_max = fc2.end_order
+    try:
+        r1_min = fc1.start_order
+        r1_max = fc1.end_order
+        r2_min = fc2.start_order
+        r2_max = fc2.end_order
+    except AttributeError:
+        # If we are on first run, some of these could be None.
+        return False
     return (r1_min == r2_min and r1_max == r2_max) or \
            (r1_min < r2_max and r2_min < r1_max)