[PATCH] D15604: Changes in conversion cost model for X86 target

[Nadav Rotem via llvm-commits]

nadav added inline comments.

================
Comment at: ../lib/Target/X86/X86TargetTransformInfo.cpp:812
@@ -805,4 +811,3 @@
 
-  // The function getSimpleVT only handles simple value types.
-  if (!SrcTy.isSimple() || !DstTy.isSimple())
-    return BaseT::getCastInstrCost(Opcode, Dst, Src);
+  MVT SrcVT;
+  MVT DstVT;
----------------
Elena, I don't understand the logic below. It looks like you are re-implementing type legalization in the code model code. Why not just use getTypeLegalizationCost ?

Can you give an example where the existing logic fails?


Repository:
  rL LLVM

http://reviews.llvm.org/D15604