[PATCH] D15553: PR25717: fatal IO error writing large outputs to console on Windows

[Aaron Ballman via llvm-commits]

aaron.ballman added a comment.

In http://reviews.llvm.org/D15553#313429, @ygao wrote:

> Ok, this does make my codes simpler. I have a question: the IsWindows8OrGreater() API comes from VersionHelpers.h, which is part of Visual Studio 2013. Will this change cause problems for, say, mingw or cygwin builds (I am not sure whether we support them)?


That's a good question that I don't know the answer to. I don't know if we dropped mingw support (and only support mingw-w64).

VersionHelpers.h is part of the Win32 SDK, but I have no idea how current those projects are at keeping up. If they don't keep up, then I think it would be reasonable to add a declaration to WindowsSupport.h and write our own definition based on GetVersionEx().


http://reviews.llvm.org/D15553