[PATCH] D15541: [PGO] generate different version for FE instrumentation and IR level instrumentation profiles

[Xinliang David Li via llvm-commits]

Please rebase your patch. The portability macro to be used is
COMPILER_RT_WEAK.

David

On Thu, Dec 17, 2015 at 2:03 PM, Rong Xu <xur at google.com> wrote:
> xur added inline comments.
>
> ================
> Comment at: lib/profile/InstrProfiling.c:22
> @@ +21,3 @@
> +/* IR level instrumentation declares a strong symbol and sets the value to 1. */
> +__attribute__((weak)) int __llvm_profile_ir_level = 0;
> +
> ----------------
> davidxl wrote:
>> use macro LLVM_ATTRIBUTE_WEAK
> Macro LLVM_ATTRIBUTE_WEAK is defined in llvm/Support/Compiler.h. It seems to me we should include that header here (also that is  a c++ header).
> There are also other direct uses of __attribute__((weak)) in InstrProfilingFile.c.
>
>
> http://reviews.llvm.org/D15541
>
>
>