[PATCH] D15390: [ThinLTO] Launch importing backends in parallel threads from gold plugin

Rafael Espíndola via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 17 13:54:07 PST 2015


We should probably refactor splitCodeGen. It is odd that now we have
two parallel codegen paths. With thinLTO we already multiple BC files,
so it should probably look something like

if (SplitForParallelCodeGen)
  ProduceMultipleModules();
Create the tasks.

Each task handles one bc file, which may be one of the original ones
if using thinLto or one of the split ones.





On 17 December 2015 at 16:43, Rafael Ávila de Espíndola
<llvm-commits at lists.llvm.org> wrote:
> rafael added a comment.
>
> I got this warning:
>
> /home/espindola/llvm/llvm/tools/gold/gold-plugin.cpp:133:17: warning: private field 'F' is not used [-Wunused-private-field]
>
>   claimed_file *F
>
>
> ================
> Comment at: tools/gold/gold-plugin.cpp:979
> @@ +978,3 @@
> +  // splitCodeGen will use a single thread since this has one entry.
> +  std::vector<llvm::raw_pwrite_stream *> OSPtrs(1);
> +  OSPtrs[0] = OS;
> ----------------
> If you change codegenImpl to take an ArrayRef you don't have to do this.
>
>
> http://reviews.llvm.org/D15390
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list