[PATCH] D15553: PR25717: fatal IO error writing large outputs to console on Windows

[Aaron Ballman via llvm-commits]

aaron.ballman added inline comments.

================
Comment at: lib/Support/raw_ostream.cpp:62
@@ +61,3 @@
+#define NOMINMAX
+#include <windows.h>
+#endif
----------------
Please include WindowsSupport.h instead of doing this.

================
Comment at: lib/Support/raw_ostream.cpp:572
@@ +571,3 @@
+static bool IsWindows7OrEarlier() {
+  unsigned Version = ::GetVersion();
+  unsigned MajorVersion = (Version & 0xFF);
----------------
GetVersion() is deprecated, you should be using IsWindows8OrGreater() instead (https://msdn.microsoft.com/en-us/library/windows/desktop/dn424961(v=vs.85).aspx).


http://reviews.llvm.org/D15553