[PATCH] D15191: [ELF] Support PHDRS command

Denis Protivensky via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 17 04:26:01 PST 2015


denis-protivensky added inline comments.

================
Comment at: ELF/Writer.cpp:912
@@ +911,3 @@
+  for (StringRef Name : Phdrs) {
+    auto It = PhdrNameToIndices.find(Name);
+    if (It == std::end(PhdrNameToIndices))
----------------
ruiu wrote:
> Please do not use `auto` here as the actual type is not obvious in this local context.
I thought we agreed to use `auto` for cases when returning iterators from methods like `find` and similar, no?


http://reviews.llvm.org/D15191





More information about the llvm-commits mailing list