[PATCH] D15531: Change linkInModule to take a std::unique_ptr

[Rafael Espíndola via llvm-commits]

r255842. Thanks!

On 16 December 2015 at 17:44, Eric Christopher <echristo at gmail.com> wrote:
> echristo added a comment.
>
> Couple more inline comments, but the C API stuff as far as policy is ok now.
>
> Thanks!
>
> -eric
>
>
> ================
> Comment at: include/llvm-c/Linker.h:44
> @@ -40,1 +43,3 @@
>
> +/* Unlike LLVMLinkerMode this function:
> +   * Doesn't take an unused parameter.
> ----------------
> Typo.
>
> Best to just describe the function completely with a note of what it also doesn't do so that the end of deprecation removal is easier for LLVMLinkModules?
>
> ================
> Comment at: include/llvm/Linker/Linker.h:51
> @@ -50,3 +50,3 @@
>
> -  static bool linkModules(Module &Dest, Module &Src,
> -                          unsigned Flags = Flags::None);
> +  /// This exists to implement a deprecate C api. Don't use for anything else.
> +  bool linkInModuleForCAPI(Module &Src);
> ----------------
> "deprecated" and go ahead and specify which one so that a grep will find this.
>
>
> http://reviews.llvm.org/D15531
>
>
>